Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News Feed + React Native #735

Merged
merged 20 commits into from
Jan 15, 2016
Merged

News Feed + React Native #735

merged 20 commits into from
Jan 15, 2016

Conversation

aaronschachter
Copy link
Contributor

Adds React Native into the project, and uses it to render the LDT News Feed.

TODO:

  • Add build step to avoid manually deleting/adding main.jsbundle (Build step for compiling React main.jsbundle #752)
  • Complete News Story (add Date, Cause, list item bullet-point images) -- to be handled in separate GH issues (e.g. NewsFeed Date and Cause header #739, NewsFeed bulletpoint images #741)
  • Update README to point to wiki
  • Update wiki with basics on getting project up and running in React Native
    • to start npm (from the project directory): (JS_DIR=pwd/ReactComponent; cd node_modules/react-native; npm run start -- --root $JS_DIR)
    • to bundle the JS files (again from project directory): curl 'http://localhost:8081/index.ios.bundle?platform=ios&dev=true' -o main.jsbundle

@@ -36,6 +38,19 @@
</dict>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>NSAppTransportSecurity</key>
<dict>
<key>NSAllowsArbitraryLoads</key>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another todo: Restrict the domains to only the LTD News WP domains? Or do we need this here in order to render any full article URL in the LDTNewsArticleViewController ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #751 to commit against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant