Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set header timeouts in React fetch requests #823

Open
aaronschachter opened this issue Feb 11, 2016 · 3 comments
Open

Set header timeouts in React fetch requests #823

aaronschachter opened this issue Feb 11, 2016 · 3 comments
Assignees
@aaronschachter
Labels
medium #networking @react-native

Comments

@aaronschachter
Copy link
Contributor

https://github.com/andris9/fetch#options
@aaronschachter aaronschachter self-assigned this Feb 11, 2016
@aaronschachter aaronschachter added this to the Cheezburger 1.0.1 milestone Feb 11, 2016
@aaronschachter
Copy link
Contributor Author

Not as easy as expected. Refs facebook/react-native#2556

@aaronschachter aaronschachter modified the milestone: Cheezburger 1.0.1 Feb 26, 2016
@jonuy
Copy link
Collaborator

jonuy commented Mar 9, 2016

Are you coming across scenarios where the fetch doesn't timeout?

At least with the news feed on the Android side it looks like it's always around 30 seconds.

imo probably not a launch blocker, but a v2 UX fix if that feels too long.

@aaronschachter
Copy link
Contributor Author

The fetch command doesn't timeout if I use the Xcode developer tools "Very bad network" connection... because I think it needs code to make the Promise cancellable (per #823 (comment))

@aaronschachter aaronschachter mentioned this issue Mar 17, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronschachter aaronschachter

Labels
medium #networking @react-native
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonuy @aaronschachter