Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sagas): add mysql store #100

Merged
merged 11 commits into from
Mar 18, 2021
Merged

feat(sagas): add mysql store #100

merged 11 commits into from
Mar 18, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Mar 18, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #100 (cb730d8) into master (7090306) will increase coverage by 0.06%.
The diff coverage is 76.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   75.95%   76.02%   +0.06%     
==========================================
  Files          75       78       +3     
  Lines        2866     2995     +129     
==========================================
+ Hits         2177     2277     +100     
- Misses        516      539      +23     
- Partials      173      179       +6     
Impacted Files Coverage Δ
dtx/sagas/registry.go 92.59% <ø> (ø)
leader/dependency.go 88.37% <0.00%> (-2.11%) ⬇️
queue/dependency.go 82.55% <0.00%> (-0.98%) ⬇️
dtx/sagas/mysqlstore/dependency.go 53.12% <53.12%> (ø)
dtx/sagas/mysqlstore/mysql_store.go 83.54% <83.54%> (ø)
dtx/sagas/dependency.go 93.61% <85.71%> (-1.51%) ⬇️
dtx/sagas/mysqlstore/migrations.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7090306...cb730d8. Read the comment docs.

@Reasno Reasno requested review from GGXXLL and nfangxu March 18, 2021 09:48
@Reasno Reasno merged commit a351f54 into master Mar 18, 2021
@Reasno Reasno deleted the mysqlstore branch March 18, 2021 10:32
Reasno added a commit that referenced this pull request Mar 18, 2021
* fix: logging logfmt use sync-logger

* feat(sagas): add mysql store (#100)

* test: fix non-exist bucket

* feat(sagas): add mysql store

* doc: add comment

* fix: alter constructor

* fix: tests

* refactor: block cleanup call

* refactor: block cleanup call

* test: improve coverage

* test: improve coverage

* test: improve coverage

* test: improve coverage

* test: logging NewLogger add empty test

* fix: logging logfmt use sync-logger

* test: logging NewLogger add empty test

* test: NewLogger test logfmt

Co-authored-by: 谷溪 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants