Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python client #93

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Fix Python client #93

merged 4 commits into from
Jan 2, 2024

Conversation

Pwuts
Copy link
Contributor

@Pwuts Pwuts commented Jan 2, 2024

The Python client is currently broken (#91) and was built using an outdated generator. There are also some other issues (#92) with it, so here's a bundle of fixes. :)

Changes

  • Update generator from python-nextgen to python-pydantic-v1
  • Fix line-endings in scripts/generate.sh
  • Updated build script and config for Python client
  • Built new Python client from schema
  • Updated README

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
agentprotocolai ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:04pm

@Pwuts Pwuts marked this pull request as draft January 2, 2024 13:49
@Pwuts

This comment was marked as outdated.

Pwuts added 3 commits January 2, 2024 15:01
- Added .gitignore and .openapi-generator-ignore files
- Added openapitools.json configuration file
- Updated generate.sh script to use `python-pydantic-v1` generator, set package version dynamically
- Build the Python client from the newest schema and with the latest version of the `python-pydantic-v1` OpenAPI Generator
- Bump package version to v1.1.0
- Update dependency versions
@Pwuts Pwuts force-pushed the fix-python-client branch from 91de9d8 to c96f2d5 Compare January 2, 2024 14:04
@Pwuts
Copy link
Contributor Author

Pwuts commented Jan 2, 2024

Update: tested, works

@Pwuts Pwuts marked this pull request as ready for review January 2, 2024 14:18
@ntindle
Copy link

ntindle commented Jan 2, 2024

LGTM

@jzanecook
Copy link
Collaborator

Thanks, Pwuts!

@jzanecook jzanecook merged commit 4ed64c6 into Div99:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] list_agent_task* endpoints on Python client are broken
3 participants