-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix : Models : updated additional_input #89
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@vignesh14052002 Can you join the meeting with us at 9:30am PST at the foundation discord? https://discord.com/invite/bJnNh666C3 Let's get this merged and resolved. |
@jzanecook to make sure that the test suite covers the case. |
Checked the test suite, this is currently failing. |
@jzanecook how to run the test suite? i ran |
@jzanecook maybe the failed test cases are from js-sdk , i see the test cases are already failing in main , so reverted my js-sdk changes , you can review the python part alone |
sure |
https://agentprotocol.ai/compliance here is how you test. |
@hackgoofer checked it , test cases passed |
@hackgoofer @jzanecook Remainder! , seems you forgot to merge this PR |
Pull Request
This pull request contains a fix for v1 API endpoints for create task and execute step not accepting
additional_input
parameter , For more details refer this issue #82Description
Issue :
v1 API endpoints for create task
[POST] /ap/v1/agent/tasks
and execute step[POST] /ap/v1/agent/tasks/{taskid}/steps
not acceptingadditional_input
parameterReason :
The pydantic models Task and Step has not configured
additional_input
propertyChanges :
Made
additional_input
property to typeOptional[Dict[str, Any]]
in python sdkChecklist
Please review and check the following items to ensure your pull request can be processed smoothly:
My code adheres to the project's coding standards and style guidelines.
I have tested my changes thoroughly, including unit tests where applicable.
I have updated the documentation to reflect any changes made in this pull request.
My branch is up-to-date with the latest changes from the main branch.
I have received code review feedback and addressed any comments or concerns.
References, Fixes and Closes