v1 Update #66
v1 Update #66
Conversation
Renamed `operationId` for `listAgentTasks` from `listAgentTasksIDs` to `listAgentTasks`
Removed newman command from the test script that doesn't test against the OpenAPI spec. Added `report.html` to the .gitignore in case any reports are generated within the `testing_suite` folder, or anywhere else.
| @@ -1632,7 +1632,7 @@ def upload_agent_task_artifacts_with_http_info( | |||
| } | |||
|
|
|||
| return self.api_client.call_api( | |||
| "/agent/tasks/{task_id}/artifacts", | |||
There was a problem hiding this comment.
could we move those version into an env variable? So that future changes can be easier?
There was a problem hiding this comment.
We likely can, yes. I want to move the client into its own repository as well.
|
|
||
| agent_protocol_contract_testing_results=$? | ||
| newman run https://raw.githubusercontent.com/AI-Engineers-Foundation/agent-protocol/main/testing_suite/agent_protocol_v1.json \ |
There was a problem hiding this comment.
this URL shows up as empty for me. Is this intended?
There was a problem hiding this comment.
This URL will exist once it's merged. Otherwise, currently it would be this:
https://raw.githubusercontent.com/AI-Engineers-Foundation/agent-protocol/9c63b4ce65793459b7ce9b0c1a08df14b7a64cca/testing_suite/agent_protocol_v1.json
Which is way too long lol
There was a problem hiding this comment.
Although it may be helpful for future versions to make it belong to a specific commit rather than the main branch at whatever state it's in currently.
Only issue is you'd have to know the commit where it worked first before you changed it to that so it's a double commit/merge combo. Maybe it could be automated in a workflow.
There was a problem hiding this comment.
Good point. Okay sounds good.
/ap/v1/to all endpoints