Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Allow Pagination #53

Merged
merged 3 commits into from
Aug 29, 2023
Merged

RFC Allow Pagination #53

merged 3 commits into from
Aug 29, 2023

Conversation

waynehamadi
Copy link
Collaborator

@waynehamadi waynehamadi commented Aug 28, 2023

List tasks, artifacts and steps in a paginated way.

Feature name Support Pagination
Author(s) Merwane Hamadi ([email protected])
RFC PR: PR 53
Updated 2023-08-28
Obsoletes

Summary

We just want to be able to list tasks, artifacts and steps in a paginated way.

Motivation

Every app needs this. It's not really farfetched

Agent Builders Benefit

  • They can paginate their tasks, steps and artifacts.

Design Proposal

Query parameters for now.

Alternatives Considered

  • query parameter is the simplest, leanest design. We can add more later (body, headers, etc) => let's start lean.
  • for now, we won't add the pages in the response of the requests, this is another RFC.

Compatibility

  • This is backwards compatible. We're just adding things.

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
agent-protocol-docs ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 1:16am

@waynehamadi waynehamadi force-pushed the pagination branch 2 times, most recently from 71339dd to e78d1de Compare August 28, 2023 22:22
@waynehamadi waynehamadi changed the title Allow Pagination RFC Allow Pagination Aug 28, 2023
@@ -394,6 +455,7 @@ components:
description: Input prompt for the step.
type: string
example: Write the words you receive to the file 'output.txt'.
nullable: true
Copy link
Collaborator Author

@waynehamadi waynehamadi Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't want to add an RFC just for that: people don't necessarilly want to put an input here, so let's make it clear when something is nullable or not.

@vercel
Copy link

vercel bot commented Aug 29, 2023

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@SilenNaihin SilenNaihin merged commit 3fd7b4e into Div99:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants