Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2B-76] - Add test for compliance with the agent protocol #14

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

jakubno
Copy link
Contributor

@jakubno jakubno commented Jul 30, 2023

The test can be triggered by running

agent-protocol

Should I make it more future proof with something like?

agent-protocol --test

@linear
Copy link

linear bot commented Jul 30, 2023

@mlejva mlejva merged commit a7d5d8e into main Jul 30, 2023
@mlejva
Copy link
Contributor

mlejva commented Jul 30, 2023

Nice! This looks great.

@mlejva
Copy link
Contributor

mlejva commented Jul 30, 2023

I'm sorry, I missed your question @jakubno 🤦.

Should I make it more future proof with something like?
agent-protocol --test

I think that would be a good idea. I would also add a flag or an argument that would allow users to specify the whole URL with port where the agent runs. Maybe something like

agent-protocol validate http://localhost:8000

or

agent-protocol --test http://localhost:8000

What do you think?

@mlejva
Copy link
Contributor

mlejva commented Jul 30, 2023

Thinking about it. Maybe we should make it installable as a separate CLI. From my understanding of this PR, one would need to clone the repo and run the agent-protocol inside the python dir. Am I understanding it correctly?

@jakubno
Copy link
Contributor Author

jakubno commented Jul 30, 2023

No, I made it part of agent-protocol package, if you install agent-protocol. If you have active virtual environment, you should be able run the command in shell, no need to clone repo.

I thought about creating it as standalone package, but because this reasons I decided to add it as a part of agent-protocol package:

  • I wanted to use the models to check the output and didn't want to duplicate the code
  • There will be significant part of the users using agent-protocol package, so they don't have to install another package

But I am open to change it to standalone package if you think it'll be better that way

@mlejva
Copy link
Contributor

mlejva commented Jul 30, 2023

Got it. I think as long as people can just install the package then we're good. The only challenge for users might be having an active virtual env. We'll see if that's an obstacle.
So to summarize this - I think we're good. People can just do pip install agent-protocol and it'll work.

Do you think we can add the same functionality to the NPM package?

@jzanecook
Copy link
Collaborator

Do you think we can add the same functionality to the NPM package?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants