-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Update #10
Merged
Merged
Metadata Update #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added homepage, license, author, bugs, repository, and keywords entries. Removed references to module and unpkg files since tsup does not generate these. Updated files entry to include more project information, excluding src and examples directories so that they don't exist in the final package tarball (a.k.a. node_modules).
Added Typescript and Javascript examples, replicated instructions from the Python README, added link to minimal typescript example.
Closed
mlejva
reviewed
Jul 26, 2023
Looks good to me! Let's wait either for @ValentaTomas or @jakubno and merge this if they don't have any issues with it |
Added missing leading quote.
jakubno
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice improvements! 💯
I will add release pipeline in a bit so we can publish 🎉
jakubno
approved these changes
Jul 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for more information.