Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dplyr ungroup() #217

Closed
ianmcook opened this issue Nov 25, 2019 · 3 comments
Closed

Add support for dplyr ungroup() #217

ianmcook opened this issue Nov 25, 2019 · 3 comments

Comments

@ianmcook
Copy link

Would it be possible to add support for the dplyr verb ungroup()? When using the verb group_by() it is often a best practice to explicitly call ungroup() after, but it looks like ungroup() is not currently implemented in disk.frame. Thanks!

@xiaodaigh
Copy link
Collaborator

xiaodaigh commented Nov 25, 2019

Thanks for the report. The implementation is as follow :), and has been added here. If you use the latest master and chunk_ungroup. Let me know if there are more issues.

chunk_ungroup = create_dplyr_mapper(dplyr::ungroup)

At some point, I will write an article explaining how create_dplyr_mapper works. Any dplyr function can be created this way, using the create_dplyr_mapper.

@xiaodaigh
Copy link
Collaborator

iris %>% 
  as.disk.frame(nchunks = 2) %>% 
  chunk_group_by(Species) %>% 
  chunk_ungroup %>% 
  collect

this seems to work in the latest "development" branch

@ianmcook
Copy link
Author

ianmcook commented Jan 5, 2020

With the support for group_by() in disk.frame 0.3.0, could you please add support for ungroup() (without the chunk_ prefix)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants