fix onload and onerror parsing error #3707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression error induced by 299b123 where serde default got removed from
load_error
attribute ofImageData
.Also, it seems like neither the
load
nor theerror
events are used inserializeEvent
. This could be an issue when anerror
event goes unnoticed and theload_error
attribute is still set tofalse
as it is the default value forbool
.Something like this could do the trick but it might be out of scope for this PR.