-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete rsx #2421
Merged
Merged
Autocomplete rsx #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
reuses the tokens for ifmt so RA provides its HIR lowering on simple formatted strings
This was referenced Jun 11, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocompleting RSX
This PR changes the expansion of rsx slightly to enable rust analyzer to autocomplete elements, attributes, components and braces while you type partially based on this blog post. Our macro is still ambiguous while typing the first element/last attribute
To get around this, we create a completions module that can expand to both an attribute or element and let the user choose.
It also fixes a few span issues causing confusing error messages when a component prop is missing or the definition of an event handler closure was incorrect
Screen.Recording.2024-05-16.at.4.42.56.PM.mov
Breaking changes
This PR includes breaking changes to the rsx macro which requires changes in all
dioxus_element
structures. This will only effect libraries that define a custom set of elements for dioxus to useFixes #2422