Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge bug (update 6.1.0) #495

Open
BlackOrai opened this issue Jan 16, 2025 · 8 comments
Open

Forge bug (update 6.1.0) #495

BlackOrai opened this issue Jan 16, 2025 · 8 comments

Comments

@BlackOrai
Copy link

Hi,
i'm sure, that you get a lot of reports, but...
Today 16.1.2025 at 10 CET gameforge released new update to the gladiatus game and crazy addon barely works at forge/smeltery etc...Like it wasn't even active. Can you please do something about that?
Thanks a lot in advance and have a nice day.

@GramThanos
Copy link
Member

I am not sure, but I don't think anything is broken on the forge or smelt.
Some stuff broke on horreum, which is related to the #494

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 17, 2025

Like Thanos said.

You will need to be more specific, at first look, it seems only horreum was affected.

@czoicasm2
Copy link
Contributor

Actually, on Forge it's not showing anymore the available items as on horreum, from what i could investigate, the 2 regex on line 300 and 321 of forge.js is not working as expected, as a class "resource-amount" was added on the first html which stops the first from retrieving the items and additional data was added on the second one
so the one for line 300 should be something like this:
var info = content.match(/<input class="resource-amount" id="remove-resource-amount" type="number" title="[^"]+" min="[^"]+" max="[^"]+" value="[^"]+"\s+data-max="([^"]+)"\s*\/>/i);
and the one for 321, i made it work doing something like this:
info = content.match(/<select id="remove-resource-quality"[^>]*>[^<]*<option value="-1" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<option value="0" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<option value="1" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<option value="2" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<option value="3" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<option value="4" data-upgrade=".*">\n([^<]*)<\/option>[^<]*<\/select>/i);

Once this started working, the new errors from forge section came out regarding the availability.

I'll try working on that part as well and if find out a solution i'll be back 😄

@SmooKeIsOnlyOne
Copy link
Contributor

Found out what the issue was, gameforge changed the ids only on horreum for remove-resource-quality, oh forge they left it as resource-quality, so no need to change that @GramThanos

@GramThanos
Copy link
Member

Found out what the issue was, gameforge changed the ids only on horreum for remove-resource-quality, oh forge they left it as resource-quality, so no need to change that @GramThanos

We already patched that yesterday.

@SmooKeIsOnlyOne
Copy link
Contributor

As i tried the patched master, the forge had an issue as well, not showing the nr of available item by quality.

@GramThanos could you check linkedn, wanted to talk with you in private as well, if possible.

@GramThanos
Copy link
Member

As i tried the patched master, the forge had an issue as well, not showing the nr of available item by quality.

Yes, some people reported it on Discord. I haven't looked into it yet.

@GramThanos could you check linkedn, wanted to talk with you in private as well, if possible.

Ok. I accepted the inv.

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 18, 2025

You are really wanted these days, Thanos 😃

SmooKeIsOnlyOne pushed a commit to SmooKeIsOnlyOne/GladiatusCrazyAddon that referenced this issue Jan 18, 2025
GramThanos added a commit that referenced this issue Jan 18, 2025
@FrutyX FrutyX changed the title New gladiatus update broke the addon Forge bug (update 6.1.0) Jan 18, 2025
@FrutyX FrutyX added this to the v4.3.10 milestone Jan 21, 2025
@FrutyX FrutyX marked this as a duplicate of #510 Feb 1, 2025
@FrutyX FrutyX pinned this issue Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants