-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: completion time #17
Conversation
Hey @gf3 ! Thanks a lot for such a great contribution! I removed files related to your personal dev env if you don't mind. |
@DimitryDushkin sure thing! however, the dev container config makes it easy for others to automatically have a working environment to hack on this plugin. see: |
Yeah, it looks cool. But sorry I'm not super familiar with devcontainers so I'm not able to review this correctly. |
And it's not working. I forgot that Logseq actually not working when loaded just JS file. It always needs to load html. See logseq/logseq#10117 |
Updated build. Now it's working out of marketplace again. @gf3 thanks again for the contribution. If you will have a moment could you take a look at settings update issue? Settings are not applied unless you restart the app now. |
@DimitryDushkin i will have a look, thanks for the fixes. i didn't realize there was an issue with loading JS files directly in non-developer mode. my apologies for the breakage! |
This PR adds support for optionally including completion time as well as a handful of settings to configure the functionality of the plugin.
The new settings include:
"DONE, NOW, LATER, DOING, TODO, WAITING"
)true
)"completed"
)false
)"time"
)HH:mm
)I've also updated the dependencies and tidied up the build a bit (no more html).
And lastly, I've added a dev container configuration which includes all the dependencies necessary to develop this plugin.