Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainparams, tests: Fix Taproot activation and wallet_taproot.py functional test #257

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

gto90
Copy link
Member

@gto90 gto90 commented Dec 18, 2024

This pull request addresses the following changes to ensure the functionality of the wallet_taproot.py test:

  • chainparams.cpp:

    • Updated Taproot deployment parameters in CRegTestParams class to ensure accurate activation times and conditions.
    • Adjusted other consensus parameters to align with the changes required for Taproot activation.
  • wallet_taproot.py:

    • Modified the test setup to correctly initialize Taproot activation parameters.
    • Enhanced the test logic to ensure that Taproot-related descriptors are accurately imported and validated.

These changes ensure that the Taproot functionality is correctly activated and tested in the DigiByte Core environment.

Motivation

The modifications are necessary to fix the wallet_taproot.py functional test, which ensures the correct generation and spending of P2TR (Pay-to-Taproot) addresses.

Testing

  • Ran the wallet_taproot.py functional test suite and confirmed that all tests pass successfully.
  • Verified that Taproot-related descriptors are correctly handled in activated and non-activated scenarios.

Additional Notes

  • No changes to the documentation or other test suites are required as part of this update.

This commit fixes the wallet_taproot.py functional test by correctly setting the taproot activation in chainparams.cpp for the CRegTestParams.  It also resolves node connection and fee issues in the functional test itself.
@gto90 gto90 added the bug Something isn't working label Dec 18, 2024
@gto90 gto90 self-assigned this Dec 18, 2024
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Great work @gto90. Changes look clean, wallet compiles, runs, and when I boot into regtest mode I get the correct response for taproot activation from getblockchaininfo.

Now for fixing final python test, and then we should probably run through a taproot activation process on testnet, or at least a local modified testnet.

I will then need to add a page to the stats site to track activation process.

Screenshot 2024-12-18 at 8 20 32 AM

Screenshot 2024-12-18 at 9 16 35 AM

@beggsdl
Copy link

beggsdl commented Dec 18, 2024

@JaredTate I am still mining Testnet, so let me know if you need me to do anything for this.

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK.

@ycagel ycagel merged commit bfb4abc into develop Dec 18, 2024
1 check passed
@JaredTate
Copy link

@JaredTate I am still mining Testnet, so let me know if you need me to do anything for this.

Thank you for continuing to support Testnet! I am thinking its time we reset it with a final 8.22 release. I will look into that and work on a PR for it. We can also put it up on DigiHash.

@gto90 gto90 deleted the bugfix/test-wallet_taproot branch December 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants