Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port 8333 to 12024. #166

Merged
merged 7 commits into from Feb 1, 2024
Merged

Change port 8333 to 12024. #166

merged 7 commits into from Feb 1, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 1, 2024

Change port 8333 (Bitcoin) to 12024 (DigiByte). If this pr get approved. Then there is no more Bitcoin port in the DigiByte project.

Folder src
netbase.h Ports from 8333 to 12024 in a comment

Folder src/rpc
net.cpp For the Gui && RPC Ports from 8333 to 12024

Folder src/test ( Unit tests )
addrman_tests.cpp Ports from 8333 to 12024
net_tests.cpp Ports from 8333 to 12024
netbase_tests.cpp Ports from 8333 to 12024

GUI and RPC Before PR:
8333

Screenshot from 2024-02-01 10-40-06

After PR:
12024

Jan added 7 commits February 1, 2024 00:26
8333 to 12024
8333 >> 12024
port 8333 >> 12024
8333 to 12024
8333 >> 12024
8333 >> 12024
8333 >> 12024
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Compiles and runs great. Thanks for catching this!

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Thanks for effort @Jongjan88!

@ycagel ycagel merged commit 2df7b0a into DigiByte-Core:develop Feb 1, 2024
@ghost ghost mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants