This PR introduces support for GUIX cross compilations #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rences 'extern "C"'
… digibyte-cli and added libxcb to allowed symbols for produced binaries. glibc minimum requirement set to 2.18
======================================================================
ERROR: test_revocation_mode_soft (tests.test_validate.ValidateTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/guix-build-python-certvalidator-0.1-1.e5bdb4b.drv-0/source/tests/test_validate.py", line 85, in test_revocation_mode_soft
validate_path(context, path)
File "/tmp/guix-build-python-certvalidator-0.1-1.e5bdb4b.drv-0/source/tests/../certvalidator/validate.py", line 50, in validate_path
return _validate_path(validation_context, path)
File "/tmp/guix-build-python-certvalidator-0.1-1.e5bdb4b.drv-0/source/tests/../certvalidator/validate.py", line 358, in _validate_path
raise PathValidationError(pretty_message(
certvalidator.errors.PathValidationError: The path could not be validated because the end-entity certificate expired 2022-01-14 12:00:00Z
…uilds (as described in bitcoin/bitcoin#22526)
This reverts commit 7f41c98.
|
A good side effect of this PR is that it fixes all the CI checks too 🎉 |
j50ng
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
ACK- tested build successfully. Approx ~4hrs w/ Ubuntu on Intel Core i7-6700K @ 4.00GHz - 4 cores 16Gb ram. Will test w/ Docker on Ubuntu next. Great work @SmartArray!
JaredTate
approved these changes
Mar 14, 2023
gto90
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
tACK
Great job on this @SmartArray ! I am approving this PR while also raising the following GitHub Issue to resolve the issues building for Apple Silicon. I think it is appropriate for a release candidate but the aforementioned issue should be resolved prior to a general release.
gto90
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUIX Support
After a few brutal days, I finally got the GUIX cross compilation working. It will produce binaries for the following architectures:
arm-linux-gnueabihfaarch64-linux-gnuriscv64-linux-gnupowerpc64-linux-gnupowerpc64le-linux-gnux86_64-w64-mingw32x86_64-apple-darwin18Usage
Ubuntu
On Debian/Ubuntu you can use
apt install guixto installguixand run./contrib/guix/guix-build.For detailed instructions, refer to the docs https://github.com/DigiByte-Core/digibyte/tree/develop/contrib/guix.
MacOS/Windows
For Mac OS and Windows you can use
dockerand these instructions to run the GUIX build.https://github.com/DigiByte-Core/DigiByte-GUIX-Docker/tree/main