Correction to matrix slicing for start point of AddSubMatrix #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smoke test demostrating that generates index out of bounds.
|
I did some more checks and review with @byoyo and this looks good. I'll go ahead with the merge and release of a test version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've traced through an issue we hit with array slicing. I believe it's supplying "row finish" rather than "column start" which doesn't match how it's used:
DiffSharp/src/DiffSharp/AD.Float32.fs
Lines 2358 to 2359 in 855b192
Smoke test demonstrating index out of bounds.