vimeo plugins not working #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signatuare call to backend must have changed at some point and requires 'config' as a parameter Query to ES in the analytics plugin needed to be updated (not sure it is correct though)
|
👍 |
|
that ES query update looks good (needed for ES > 1.0), i just verified it. the thing with the config objects is, there's a canonical way to default to the standard config, so if you could update your pr for just the query thing, i'll merge that |
|
@Dieterbe that should be ok now |
Dieterbe
added a commit
that referenced
this pull request
Aug 7, 2014
update ES query in vimeo plugin for ES > 1.0
|
thanks guys, and have fun with it B-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to see how plugins work here is an updated version to have a working demo