Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add telemetry library #409

Merged
merged 6 commits into from
Feb 12, 2025
Merged

add telemetry library #409

merged 6 commits into from
Feb 12, 2025

Conversation

iamvigneshwars
Copy link
Contributor

No description provided.

@iamvigneshwars iamvigneshwars force-pushed the telemetry-library branch 17 times, most recently from 0d1047b to 47a513b Compare February 3, 2025 10:14
@iamvigneshwars iamvigneshwars changed the title Telemetry library add telemetry library Feb 3, 2025
@iamvigneshwars iamvigneshwars force-pushed the telemetry-library branch 7 times, most recently from 907d4c0 to 6a531d5 Compare February 3, 2025 13:02
@iamvigneshwars iamvigneshwars self-assigned this Feb 3, 2025
@iamvigneshwars iamvigneshwars added enhancement New feature or request rust Pull request that updates Rust code labels Feb 3, 2025
@iamvigneshwars iamvigneshwars marked this pull request as ready for review February 3, 2025 13:08
garryod
garryod requested changes Feb 3, 2025
View reviewed changes
telemetry/src/lib.rs Outdated Show resolved Hide resolved
sessionspaces/src/main.rs Outdated Show resolved Hide resolved
telemetry/Cargo.toml Outdated Show resolved Hide resolved
sessionspaces/Dockerfile Outdated Show resolved Hide resolved
graph-proxy/Dockerfile Outdated Show resolved Hide resolved
@garryod
Copy link
Member

garryod commented Feb 3, 2025

Is this the point where we want a top level services directory and a cargo workspace?

@iamvigneshwars iamvigneshwars force-pushed the telemetry-library branch 6 times, most recently from c702620 to 00cf447 Compare February 6, 2025 14:54
garryod
garryod requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few little bits and pieces

backend/graph-proxy/Cargo.toml Outdated Show resolved Hide resolved
backend/telemetry/src/lib.rs Outdated Show resolved Hide resolved
backend/Dockerfile.sessionspaces Outdated Show resolved Hide resolved
backend/Dockerfile.graph-proxy Outdated Show resolved Hide resolved
@iamvigneshwars iamvigneshwars force-pushed the telemetry-library branch 3 times, most recently from 9c846de to 77bfc5d Compare February 7, 2025 10:02
garryod
garryod requested changes Feb 12, 2025
View reviewed changes
backend/sessionspaces/src/main.rs Outdated Show resolved Hide resolved
backend/telemetry/src/lib.rs Outdated Show resolved Hide resolved
backend/Dockerfile.graph-proxy Outdated Show resolved Hide resolved
@iamvigneshwars iamvigneshwars force-pushed the telemetry-library branch 2 times, most recently from 664074e to a12ca96 Compare February 12, 2025 12:29
garryod
garryod requested changes Feb 12, 2025
View reviewed changes
backend/telemetry/src/lib.rs Outdated Show resolved Hide resolved
garryod
garryod approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamvigneshwars iamvigneshwars merged commit 6cb1874 into main Feb 12, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garryod garryod garryod approved these changes

Assignees

@iamvigneshwars iamvigneshwars

Labels
enhancement New feature or request rust Pull request that updates Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvigneshwars @garryod