Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

787 Update sample status field correctly #836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Feb 18, 2025

Fixes

Instructions to reviewer on how to test:

  1. BLSampleStatus should now be logged against the correct sample instead of only the first sample
  2. BLSampleStatus updates should now only be triggered once on an exception instead of once for each level of bluesky run nesting it escapes.

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (45ba7c6) to head (46f26f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   87.33%   87.34%           
=======================================
  Files         104      104           
  Lines        6995     7000    +5     
=======================================
+ Hits         6109     6114    +5     
  Misses        886      886           
Components Coverage Δ
i24 SSX 73.95% <ø> (ø)
hyperion 96.34% <100.00%> (+<0.01%) ⬆️
other 96.24% <100.00%> (ø)

Copy link
Collaborator

@shihab-dls shihab-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and tests look comprehensive to me! Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants