-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1034 pressure cell openseq type #1037
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 160 160
Lines 6599 6599
=======================================
Hits 6446 6446
Misses 153 153 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
|
||
super().__init__(name) | ||
|
||
def set(self, value: ValveControlRequest | ValveOpenSeqRequest) -> AsyncStatus: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must: I don't think you can do this. You need to stick to the function definition of Movable
in case we're calling this with a keyword arg e.g device.set(value=10)
. The reason the IDE isn't picking this up is that you also need ValveControl
to inherit from Moveable
. Same with FastValveControl
5aa8ce8
to
6c70538
Compare
Fixes #1034
Instructions to reviewer on how to test:
dodal connect p38
Checks for reviewer
dodal connect ${BEAMLINE}