Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1034 pressure cell openseq type #1037

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

barnettwilliam
Copy link
Contributor

Fixes #1034

Instructions to reviewer on how to test:

  1. dodal connect p38
  2. Confirm the pressure cell is in the list of connected devices

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@barnettwilliam barnettwilliam requested a review from a team as a code owner February 4, 2025 16:13
@barnettwilliam barnettwilliam linked an issue Feb 4, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (cdc6652) to head (6c70538).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         160      160           
  Lines        6599     6599           
=======================================
  Hits         6446     6446           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment


super().__init__(name)

def set(self, value: ValveControlRequest | ValveOpenSeqRequest) -> AsyncStatus:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must: I don't think you can do this. You need to stick to the function definition of Movable in case we're calling this with a keyword arg e.g device.set(value=10). The reason the IDE isn't picking this up is that you also need ValveControl to inherit from Moveable. Same with FastValveControl

@stan-dot stan-dot force-pushed the 1034-pressure-cell-openseq-type branch from 5aa8ce8 to 6c70538 Compare February 7, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure jump cell incorrect OPENSEQ type
2 participants