Adds support for macOS and tvOS targets using Carthage and SwiftPM #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
surpher
commented
Sep 27, 2017
surpher
commented
- Replaces the .xcodeproj to support different platforms iOS, macOS and tvOS by also adding different schemes and links to correct frameworks per platform
- Changes the project file structure to accomodate Swift Package Manager (SwiftPM doesn't like Obj-C files)
- Updates TravisCI config to test builds for multiple platforms (iOS9, iOS10 and iOS11, tvOS9, tvOS10, macOS x86_64)
- Updates README.md and CONTRIBUTING.md to align with these changes
- iOS 9.3 - macOS 10.10 - tvOS 9.2
TravisCI complained that latest swiftlint was already installed.
- Nimble framework does not contain bitcode
Dependency Nimble does not (yet) support watchOS
- tests on iOS 11, 10.3.1 and 9.3 - tests on macOS x86_64
- Scanfile no longer valid as framework supports macOS as well - Adds contributing information how to test for different platforms and package managers - Fixes code coverage settings
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage ? 86.25%
=========================================
Files ? 6
Lines ? 371
Branches ? 0
=========================================
Hits ? 320
Misses ? 51
Partials ? 0 |
- Tests with AppleTV 4K - Bumps up the Swift version in .swift-version file
|
Not sure what happened with codecov here... :| |
# Conflicts: # .travis.yml # Cartfile.resolved # PactConsumerObjCTests/PactObjectiveCTests.m # PactConsumerSwift.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.