-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum version of PyDSTool, allowing scipy version to be unpinned #338
Set minimum version of PyDSTool, allowing scipy version to be unpinned #338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=========================================
+ Coverage 68.73% 68.94% +0.2%
=========================================
Files 9 2 -7
Lines 5754 5696 -58
Branches 1572 1556 -16
=========================================
- Hits 3955 3927 -28
+ Misses 1410 1382 -28
+ Partials 389 387 -2
Continue to review full report at Codecov.
|
94a30b8
to
f4de0ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a couple of notebooks and I don't see any problem with them.
However, I can't see the scipy version...
$ python -c "import scipy; print(scipy.__version__)"
Traceback (most recent call last):
File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'scipy'
@joefresna Works for me. Are you definitely using the right interpreter? What does the following show?
|
I thought I had to create a new environment to test things with new package versions.
|
@joefresna I think you're missing steps 6 and 7 from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad. I solved it.
The changes look fine to me
Allows use of scipy >= 1.0.0.
scipy.integrate functionality may have changed so this definitely needs reviewing.
Closes #63