Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/google signin #57

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

JeevaRamanathan
Copy link
Contributor

@JeevaRamanathan JeevaRamanathan commented Oct 24, 2023

Fix for #49
While merging please do create a project in https://console.cloud.google.com/ and under Apis and Services i. create a OAuth 2.0 client id for web application and replace the client id in index.html (line 59). ii) Also add the Authorized JavaScript origins in OAuth 2.0 of the web app end point. If anything goes wrong kindly let me know!

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for board-dhanushnehru ready!

Name Link
🔨 Latest commit c1add18
🔍 Latest deploy log https://app.netlify.com/sites/board-dhanushnehru/deploys/65393762c5be570008974ef8
😎 Deploy Preview https://deploy-preview-57--board-dhanushnehru.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DhanushNehru
Copy link
Owner

Hi @JeevaRamanathan the client id etc, can that be as environment variables.
And also the steps to be followed can you add images as well

@JeevaRamanathan
Copy link
Contributor Author

JeevaRamanathan commented Oct 25, 2023

Hi @DhanushNehru ,

  1. As html is a markup language it does not handle env variables, so now I have approached that in a different way using config,json file, so the client_id can be directly updated in config file.

2.Steps to be followed to enable and get the data-client_id

  • Create a Google Cloud Project:
    Go to the Google Cloud Console (https://console.cloud.google.com/) and create a new project.
    image
    image

  • Configure OAuth Consent Screen:
    In the Google Cloud Console, navigate to created project's "APIs & Services" > "OAuth consent screen."
    Configure the OAuth consent screen with the all required details like app name, user support email, etc.

  • Create OAuth 2.0 Client ID:
    Navigate to "APIs & Services" > "Credentials."
    Click on the "Create Credentials" button and select "OAuth client ID."
    Choose the application type as Web application.
    Add authorized JavaScript origins for the application. (i.e https://board-dhanushnehru.netlify.app/)
    Once created, the "Client ID" will be generated. Replace that client id in the config.json file

image

Please follow the above steps and if you are facing any issues please let me know

@DhanushNehru DhanushNehru merged commit e992393 into DhanushNehru:main Oct 26, 2023
@DhanushNehru
Copy link
Owner

Thanks for your contribution @JeevaRamanathan , if you can update the readme.md / contribution.md guidelines

Or create an issue to update those, it would be very helpful for new users

@JeevaRamanathan
Copy link
Contributor Author

Hi @DhanushNehru, Sure! I have raised a PR updating readme.md. #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants