Remove a block which failed with the wrong error

[psalaberria002]

We had a case where the API had some users with the MEMBER role, but the Terraform config was trying to set the OWNER role to them.

We got Error: [ERROR] Error updating memberships: [ERROR] Error updating groupMember ([email protected]): nested groups should be role MEMBER which made no sense.

Is there any reason for that condition to be in the reconcile function?

[DeviaVir]

Yes, this condition prevents users trying to add nested groups as role OWNER (which is not allowed by the admin API)

[psalaberria002]

That happens in a different block in the same file. This block is hit even when the member is not a group. I suspect is coming from an old copy paste.

[psalaberria002]

@DeviaVir can you have another look?

[DeviaVir]

I see:

terraform-provider-gsuite/gsuite/resource_group_members.go

Lines 279 to 282 in dc6b8e9

	if isGroup == true {
	if role != "MEMBER" {
	return fmt.Errorf("[ERROR] Error creating groupMember (%s): nested groups should be role MEMBER", email)
	}

Ack.