Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch] Add table detector to Markdown detector #56

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

agayev169
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Markdown detector does not detect Markdown tables at all.

Issue Number: N/A

What is the new behavior?

Now Markdown detector matches a table and detects that a provided string is a Markdown data.

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this. NOTE: Not related
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass. NOTE: CertificateDecoderCommandLineToolTests fail, but this is clearly not related to what I've done. Will try to check what is the failure reason.
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler
Copy link
Collaborator

veler commented Aug 24, 2024

Hi,
This is awesome, thank you !

@veler veler merged commit 7714b0c into DevToys-app:main Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants