Rename 'pageId' term to 'windowId' (close #4586) #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirovboris
approved these changes
Dec 27, 2019
|
❌ Tests for the commit 2ef1774 have failed. See details: |
|
❌ Tests for the commit ad68d02 have failed. See details: |
miherlosev
force-pushed
the
rename_page_id_to_window_id
branch
from
ad68d02 to
c940528
Compare
AndreyBelym
reviewed
Dec 27, 2019
|
❌ Tests for the commit 23e08f4 have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 23e08f4 have failed. See details: |
|
@testcafe-build-bot retest |
helen-dikareva
changed the title
|
❌ Tests for the commit 23e08f4 have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 23e08f4 have failed. See details: |
|
❌ Tests for the commit 60dd506 have failed. See details: |
|
❌ Tests for the commit 60dd506 have failed. See details: |
2 similar comments
|
❌ Tests for the commit 60dd506 have failed. See details: |
|
❌ Tests for the commit 60dd506 have failed. See details: |
|
@testcafe-build-bot retest |
|
@miherlosev I'll restart it |
|
✅ Tests for the commit 60dd506 have passed. See details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.