Feat: clientFunction better definition #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 3c418ce have failed. See details: |
|
Thank you for your contribution. We need some time to review new typings. |
|
Typed spread operator comes with typescript 3.0. Make sure that your update your dependencies |
AndreyBelym
approved these changes
Feb 25, 2019
|
❌ Tests for the commit edcffab have failed. See details: |
|
❌ Tests for the commit 660a035 have failed. See details: |
|
❌ Tests for the commit 660a035 have failed. See details: |
|
❌ Tests for the commit 660a035 have failed. See details: |
|
❌ Tests for the commit 660a035 have failed. See details: |
miherlosev
approved these changes
Feb 26, 2019
|
❌ Tests for the commit 660a035 have failed. See details: |
|
✅ Tests for the commit 660a035 have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
* make types more strong * add typeof null support * fix formatting issue * add clientFunction typings * fix formatting * Fix tests * Fix from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes. Generic default type is
any