Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Implement support for proxying pages inside ASAR archives (close #2033) #2043

Merged
merged 24 commits into from
Jul 25, 2019
Merged

fix Implement support for proxying pages inside ASAR archives (close #2033) #2043

merged 24 commits into from
Jul 25, 2019

Conversation

Farfurix
Copy link
Contributor

@Farfurix Farfurix commented Jun 11, 2019 •
edited
Loading

#2033

Changes

  1. Fix FileRequest (asar case).
  2. Update src/.babelrc to the Node 8 target without the @babel/plugin-transform-async-to-generator plugin.

"File not exists" error codes

  • Windows: ENOENT
  • Linux: ENOTDIR (found it on travis server tests):
ENOTDIR: not a directory,
stat \'/home/travis/build/testcafe-build-bot/testcafe-hammerhead/test/server/data/file-in-asar-archive/directory-looks-like-archive.asar/app.asar/non-exist-file.txt\'

Notes

https://electronjs.org/docs/tutorial/application-packaging:

asar archives are treated as directories

@Farfurix Farfurix requested a review from AndreyBelym June 11, 2019 13:49
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 84fc58b have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 5d67a0d have passed. See details.

miherlosev
miherlosev suggested changes Jun 13, 2019
View reviewed changes
src/request-pipeline/file-request.ts Outdated Show resolved Hide resolved
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit a8de671 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit cbaac67 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit cbaac67 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit cbaac67 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 7d82f00 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 0f1873e have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 2cfe811 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 8d139fd have passed. See details.

@Farfurix Farfurix changed the title [WIP] fix Implement support for proxying pages inside ASAR archives (close #2033) fix Implement support for proxying pages inside ASAR archives (close #2033) Jun 21, 2019
@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 2fa4c14 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 18bcb09 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 18bcb09 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 9e4d334 have passed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit af2c80a have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 9ffe53e have failed. See details.

@Farfurix
Copy link
Contributor Author

Farfurix commented Jul 8, 2019

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 9ffe53e have passed. See details.

AndreyBelym
AndreyBelym reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@AndreyBelym AndreyBelym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, just some minor remarks/tips/questions.

src/request-pipeline/file-request.ts Outdated Show resolved Hide resolved
src/utils/asar.ts Outdated Show resolved Hide resolved
src/utils/asar.ts
import { toReadableStream } from './buffer';
import path from 'path';
import fs from 'fs';
/*eslint-disable no-unused-vars*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not nice, but out of this PR's scope. I created a new issue about it: #2068

src/utils/asar.ts Outdated Show resolved Hide resolved
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit f8c399f have failed. See details.

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 7971560 have failed. See details.

@Farfurix Farfurix requested a review from VasilyStrelyaev July 25, 2019 09:21
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 0763e01 have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 0763e01 have passed. See details.

VasilyStrelyaev
VasilyStrelyaev reviewed Jul 25, 2019
View reviewed changes
src/utils/asar.ts Outdated Show resolved Hide resolved
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit af3326a have failed. See details.

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit af3326a have passed. See details.

@Farfurix Farfurix merged commit e2ab8c8 into DevExpress:master Jul 25, 2019
@Farfurix Farfurix deleted the i2033-asar branch May 26, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LavrovArtem LavrovArtem LavrovArtem requested changes

@VasilyStrelyaev VasilyStrelyaev VasilyStrelyaev left review comments

@miherlosev miherlosev miherlosev approved these changes

@AndreyBelym AndreyBelym AndreyBelym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Farfurix @testcafe-build-bot @miherlosev @AndreyBelym @LavrovArtem @VasilyStrelyaev