Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code instrumentation of the 'lenght' property is very slow #979

Closed
miherlosev opened this issue Dec 1, 2016 · 7 comments
Closed

Code instrumentation of the 'lenght' property is very slow #979

miherlosev opened this issue Dec 1, 2016 · 7 comments
Assignees
@miherlosev
Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Milestone
Sprint #8

Comments

@miherlosev
Copy link
Contributor

miherlosev commented Dec 1, 2016 •
edited
Loading

See video

Url for reproduce - http://demos.devexpress.com/bootstrap/GridView/Editing.aspx

On video we see that cascading comboboxes close very slowly.

Profiling result:
Profing result

IsShadowContainerCollection affects about 38 percent of the time.

Need to speed up instrumentation of this property.
@miherlosev miherlosev added this to the Sprint #3 milestone Dec 1, 2016
@miherlosev miherlosev self-assigned this Dec 1, 2016
@inikulin inikulin changed the title IsShadowContainerCollection method is very slowly IsShadowContainerCollection method is very slow Dec 1, 2016
@miherlosev miherlosev changed the title IsShadowContainerCollection method is very slow Instrumentation of the 'lenght' property is very slow Dec 1, 2016
@miherlosev miherlosev changed the title Instrumentation of the 'lenght' property is very slow Code instrumentation of the 'lenght' property is very slow Dec 1, 2016
@miherlosev
Copy link
Contributor Author

I'm working on this

@AlexanderMoskovkin
Copy link
Contributor

Is there any progress here?

@miherlosev
Copy link
Contributor Author

Need an additional time

@miherlosev
Copy link
Contributor Author

Our stuff (shadow ui scripts and styles) are last child nodes for body and head tags.
We can improove perfomance if we will redefine lenght for these nodes for appropriate case (appendChild, insertBefore, removeChild).
In this case we can remove code instrumentation for length property.

@romanresh
Copy link

Any news?

@miherlosev
Copy link
Contributor Author

The task is in progress

@miherlosev miherlosev modified the milestones: Sprint #5, Sprint #4 Feb 13, 2017
@churkin churkin modified the milestones: Sprint #6, Sprint #5 Mar 24, 2017
@miherlosev miherlosev modified the milestones: Planned, Sprint #7 May 16, 2017
@miherlosev miherlosev modified the milestones: Sprint #8, Planned Jun 3, 2017
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 9, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
a3dafec 
DevExpress#979)
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 13, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
681e689 
DevExpress#979)
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 14, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
9624339 
DevExpress#979)
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 14, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
db61697 
DevExpress#979)
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 16, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
e7bd5bf 
DevExpress#979)
LavrovArtem added a commit to LavrovArtem/testcafe-hammerhead that referenced this issue Jun 16, 2017
@LavrovArtem
fix Code instrumentation of the 'lenght' property is very slow (close
9c27064 
DevExpress#979)
AndreyBelym pushed a commit to AndreyBelym/testcafe-hammerhead that referenced this issue Feb 28, 2019
@LavrovArtem @AndreyBelym
fix Code instrumentation of the 'lenght' property is very slow (close
362845b 
DevExpress#979) (DevExpress#1173)

* fix `Code instrumentation of the 'lenght' property is very slow` (close DevExpress#979)

* try to fix ie9

* fix review's issues

* fix review's issues
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked Issues that were automatically locked by the Lock bot label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miherlosev miherlosev

Labels
AREA: client !IMPORTANT! STATE: Auto-locked Issues that were automatically locked by the Lock bot TYPE: bug
Projects
None yet
Milestone
Sprint #8
Development

No branches or pull requests
4 participants
@miherlosev @romanresh @churkin @AlexanderMoskovkin