Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chrome to v133 #28919

Open
wants to merge 8 commits into
base: 24_1
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/actions/run-qunit-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ runs:
if: ${{ inputs.browser == 'chrome' }}
uses: ./.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: Setup Firefox profile
if: ${{ inputs.browser == 'firefox' }}
Expand Down
13 changes: 3 additions & 10 deletions .github/actions/setup-chrome/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,10 @@ runs:
if [ -n "$CHROME_VERSION" ]; then
sudo apt-get update
sudo apt-get -y install libu2f-udev

mkdir google-chrome-setup
pushd google-chrome-setup
npm init -y
npm set //npm.pkg.github.com/:_authToken="${{ github.token }}"
npm i @devexpress/[email protected] --registry=https://npm.pkg.github.com
sudo dpkg -i node_modules/@devexpress/devextreme-google-chrome-image/google-chrome-stable_121.0.6167.184-1_amd64.deb
curl -L "https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROME_VERSION}-1_amd64.deb" > /tmp/chrome.deb
sudo dpkg -i /tmp/chrome.deb
unlink /tmp/chrome.deb
google-chrome-stable --version
popd

rm -rf google-chrome-setup
else
echo "Skip Chrome upgrade"
fi
2 changes: 1 addition & 1 deletion .github/workflows/demos_visual_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/demos_visual_tests_frameworks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: Restore npm cache
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playgrounds_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-testcafe-on-gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Setup Chrome
uses: ./devextreme/.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: DevExtreme - Install packages
working-directory: devextreme
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testcafe_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '121.0.6167.184'
chrome-version: '133.0.6943.53'

- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
17 changes: 10 additions & 7 deletions e2e/testcafe-devextreme/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ const parseArgs = require('minimist');
const testPageUtils = require('./helpers/clearPage');
require('nconf').argv();

const changeTheme = async(themeName) => createTestCafe.ClientFunction(() => new Promise((resolve) => {
const changeTheme = async(t, themeName) => createTestCafe.ClientFunction(() => new Promise((resolve) => {
// eslint-disable-next-line no-undef
window.DevExpress.ui.themes.ready(resolve);
// eslint-disable-next-line no-undef
window.DevExpress.ui.themes.current(themeName);
}),
{ dependencies: { themeName } })();
{ dependencies: { themeName } }).with({ boundTestRun: t })();

const addShadowRootTree = async function() {
const addShadowRootTree = async(t) => {
await createTestCafe.ClientFunction(() => {
const root = document.querySelector('#parentContainer');
const childNodes = root.childNodes;
Expand All @@ -29,7 +29,7 @@ const addShadowRootTree = async function() {
shadowContainer.append.apply(shadowContainer, Array.from(childNodes));

root.shadowRoot.appendChild(shadowContainer);
})();
}).with({ boundTestRun: t })();
};

let testCafe;
Expand Down Expand Up @@ -117,13 +117,16 @@ createTestCafe({

runOptions.hooks = {
test: {
before: async() => {
before: async(t) => {
// TODO: Move to a single const (look at restoreBrowserSize helper module)
await t.resizeWindow(1200, 800);

if(args.shadowDom) {
await addShadowRootTree();
await addShadowRootTree(t);
}

if(args.theme) {
await changeTheme(args.theme);
await changeTheme(t, args.theme);
}
},
after: async() => {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading