Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding instruction detailing issues around npm install using Git Bash on Windows #2492

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

FindingNamo
Copy link
Contributor

npm install can fail to fetch all necessary dependencies when run from Git Bash on Windows even if the shell is ran as Admin.

This currently leads to issues getting es-to-primitive and is-regex which leads failures like the following when finally trying to npm run server. Any other shell seems to behave correctly (cmd is fine for example).

Adding info to help in the README.

@bhollis bhollis merged commit 2e7a88f into DestinyItemManager:master Dec 18, 2017
@bhollis
Copy link
Contributor

bhollis commented Dec 18, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants