Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean #1

Merged
merged 10 commits into from
Oct 21, 2021
Merged

Clean #1

merged 10 commits into from
Oct 21, 2021

Conversation

DerThorsten
Copy link
Owner

used eslint to remove linting error/warnings

@jtpio
Copy link
Collaborator

jtpio commented Oct 21, 2021

Thanks!

FileNotFoundError: [Errno 2] No such file or directory: 'CHANGELOG.md'

We can create an empty CHANGELOG.md with the following content:

# Changelog

<!-- <START NEW CHANGELOG ENTRY> -->

<!-- <END NEW CHANGELOG ENTRY> -->

@DerThorsten
Copy link
Owner Author

I also gave you access to this repo 😺

@DerThorsten
Copy link
Owner Author

btw while testing if this works in a fresh env I stumbled over this:
jupyterlite/jupyterlite#402

README.md Outdated Show resolved Hide resolved
@DerThorsten
Copy link
Owner Author

no clue how to handle this

_ /home/runner/work/jupyter_wren_syntax/jupyter_wren_syntax/.jupyter_releaser_checkout/CHANGELOG.md: https://github.com/DerThorsten/jupyter_wren_syntax/compare/0.1.0...None _
https://github.com/DerThorsten/jupyter_wren_syntax/compare/0.1.0...None: 404: Not Found
=========================== short test summary info ============================
FAILED CHANGELOG.md::/home/runner/work/jupyter_wren_syntax/jupyter_wren_syntax/.jupyter_releaser_checkout/CHANGELOG.md <a href=https://github.com/DerThorsten/jupyter_wren_syntax/compare/0.1.0...None>
1 failed, 1 passed in 0.69s
COMMAND: pytest --noconftest --check-links --check-links-cache --check-links-cache-expire-after 604800 --disable-warnings --quiet --check-links-cache-name /home/runner/.cache/releaser-link-check/check-release-links  --check-links-ignore "https://github.com/.*/(pull|issues)/.*" --check-links-ignore "https://github.com/search?" --check-links-ignore "http://localhost.*" --ignore-glob node_modules "CHANGELOG.md" --lf

@jtpio
Copy link
Collaborator

jtpio commented Oct 21, 2021

Failure might be related to jupyter-server/jupyter_releaser#131

We could skip the link check for now. Will push a fix.

@jtpio
Copy link
Collaborator

jtpio commented Oct 21, 2021

CI is green.

@DerThorsten there is a 0.1.0 tag on the repo: https://github.com/DerThorsten/jupyter_wren_syntax/releases/tag/0.1.0

But it was not published to PyPI, right?

I created a placeholder project on PyPI for now: https://pypi.org/project/jupyter-wren-syntax/

Will proceed with the 0.1.0 release after merging this PR.

@jtpio jtpio merged commit e0a9e01 into main Oct 21, 2021
@jtpio jtpio deleted the clean branch October 21, 2021 13:12
@DerThorsten
Copy link
Owner Author

But it was not published to PyPI, right?

correct it was not deployed on PyPI, but I tried to put it on conda-forge. This is why I needed a tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants