Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read/write to JSONObject with thread-safe #99

Merged
merged 2 commits into from
Sep 19, 2024
Merged

read/write to JSONObject with thread-safe #99

merged 2 commits into from
Sep 19, 2024

Conversation

satsukies
Copy link
Member

fix #98 (comment)

SdkDeviceStatesCollector should be thread-safe for reading/writing attributes.

@satsukies satsukies self-assigned this Sep 19, 2024
@satsukies satsukies marked this pull request as ready for review September 19, 2024 06:44
@satsukies satsukies requested a review from jmatsu September 19, 2024 06:45
@satsukies satsukies mentioned this pull request Sep 19, 2024
Merged
jmatsu
jmatsu suggested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix one thing.

@satsukies satsukies requested a review from jmatsu September 19, 2024 08:47
jmatsu
jmatsu approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jmatsu jmatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@satsukies
Copy link
Member Author

satsukies commented Sep 19, 2024 •
edited
Loading

Thanks!

@satsukies satsukies merged commit cb82600 into master Sep 19, 2024
6 checks passed
@satsukies satsukies deleted the fix/device-states-collector-works-thread-safe branch September 19, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmatsu jmatsu jmatsu approved these changes

Assignees

@satsukies satsukies

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satsukies @jmatsu