Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and unarchive all javadocs which are missing at a run-time #82

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Mar 19, 2024

Close #40

The current workflow just downloads the latest release and it's basically enough if no issue occurred ever. This change fixes it to check all releases on every workflow run.

@jmatsu
Copy link
Contributor Author

jmatsu commented Mar 19, 2024

@jmatsu jmatsu marked this pull request as ready for review March 19, 2024 08:50
@jmatsu jmatsu requested review from a team and satsukies and removed request for a team March 19, 2024 08:50
Copy link
Member

@satsukies satsukies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

});
const releases = await github.paginate(opts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: actions/github-script makes easy to use GitHub APIs. nice :)

@jmatsu
Copy link
Contributor Author

jmatsu commented Mar 19, 2024

Thanks~

@jmatsu jmatsu merged commit 89d8676 into master Mar 19, 2024
7 checks passed
@jmatsu jmatsu deleted the jmatsu/fix/javadoc_hosting branch March 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the hosted javadocs are outdated or its link seems to be broken
2 participants