Provide opt-out for crash reporting and device capture features #80
+338
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.deploygate app can know the shallow-configuration via init event
jmatsu
commented
Mar 15, 2024
| @@ -102,7 +102,7 @@ public void onEvent( | |||
| } else if (DeployGateEvent.ACTION_ONESHOT_LOGCAT.equals(action)) { | |||
| String captureId = null; | |||
|
|
|||
| if (mDeployGateClient.isSupported(Compatibility.DEVICE_CAPTURE)) { | |||
| if (mHostApp.canUseDeviceCapture() && mDeployGateClient.isSupported(Compatibility.DEVICE_CAPTURE)) { | |||
There was a problem hiding this comment.
SDK cannot turn off the device capture feature completely because triggers will be fired from the client app.
jmatsu
requested review from
a team,
tnj and
satsukies
and removed request for
a team and
tnj
satsukies
approved these changes
Mar 15, 2024
| Truth.assertThat(app.canUseLogcat).isTrue(); | ||
| Truth.assertThat(app.packageName).isEqualTo("com.deploygate.sdk.test"); | ||
| Truth.assertThat(app.sdkVersion).isEqualTo(4); | ||
| Truth.assertThat(app.sdkArtifactVersion).isEqualTo("4.6.1"); | ||
| Truth.assertThat(app.activeFeatureFlags).isEqualTo(31); |
There was a problem hiding this comment.
I understood this assertion expected 31 because activeFeatureFlags has 0x11111 -> 31 when all features enabled.
|
Thank you~ 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #68
We should provide flexible configuration for users. Especially, opting-out data collection is getting important. Some of features are triggered by our client app, so SDK state must be delivered to our app through AIDL; We can know the active features from init event.