Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed SDK's artifact version in meta-data tags #79

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Mar 14, 2024

This is useful for host apps to control SDK functionalities more flexible.

NOTE: This can be overridden by developers, however, there is no problem cuz this is not an authentication/authorization stuff. Such cheat wouldn't bring any benefit to developers but may cause app crashes or unexpected behaviours.

@jmatsu jmatsu marked this pull request as ready for review March 14, 2024 08:41
@jmatsu jmatsu requested review from a team and satsukies and removed request for a team March 14, 2024 08:41
Copy link
Member

@satsukies satsukies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmatsu
Copy link
Contributor Author

jmatsu commented Mar 14, 2024

Thnkas~

@jmatsu jmatsu merged commit 4bb5b01 into master Mar 14, 2024
5 checks passed
@jmatsu jmatsu deleted the jmastu/feat/embed_sdk_version_in_meta_tag branch March 14, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants