Send foreground status to the host application and handle extensible Logcat requests #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmatsu
commented
Aug 15, 2023
•
jmatsu
commented
- Send foreground/background events to the host application
- Don't use any lifecycle API from AndroidX but ActivityLifecycleCallback is enough for this use-case.
- Foreground events may be sent before a valid service connection has been established so buffer and flush are required.
- Allow to use a capture id from Logcat request
…l sdk implementation
jmatsu
commented
Aug 15, 2023
|
|
||
| while (iterator.hasNext()) { | ||
| Map.Entry<String, Bundle> entry = iterator.next(); | ||
| invokeAction(entry.getKey(), entry.getValue(), false); |
There was a problem hiding this comment.
The current buffer mechanism is relaxed. Enough.
|
@jmatsu can I begin review this? |
|
@satsukies Yes, please review the both of this PR and another one. They are related. |
satsukies
approved these changes
Aug 17, 2023
sdk/src/main/java/com/deploygate/sdk/LogcatInstructionSerializer.java
Outdated
Show resolved
Hide resolved
…er.java Co-authored-by: satsukies <[email protected]>
|
Thank you for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.