Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Android 11's PackageVisibility #29

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Support Android 11's PackageVisibility #29

merged 1 commit into from
Jun 22, 2020

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Jun 19, 2020 •
edited
Loading

As Package Visibility changes, the explicit package element is required to find DeployGate client app.

This change will build the sample project with Android R so AGP version needs to be upgraded to 3.6.1 or higher.

@jmatsu jmatsu requested a review from tnj June 19, 2020 11:06
@jmatsu
Copy link
Contributor Author

jmatsu commented Jun 21, 2020

Ah, I remembered #25 was conflicted with this change due to AGP breaking changes. Let me address #25 first.

@jmatsu jmatsu marked this pull request as draft June 21, 2020 02:09
@jmatsu jmatsu marked this pull request as ready for review June 21, 2020 02:59
@jmatsu jmatsu changed the base branch from master to implement-get-revision June 21, 2020 03:00
@jmatsu jmatsu changed the base branch from implement-get-revision to master June 21, 2020 03:00
@tnj tnj self-assigned this Jun 22, 2020
tnj
tnj approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@tnj tnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@jmatsu
Copy link
Contributor Author

jmatsu commented Jun 22, 2020

thanks!

@jmatsu jmatsu merged commit 799c99e into master Jun 22, 2020
@jmatsu jmatsu deleted the android11_support branch June 22, 2020 02:09
@jmatsu jmatsu mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnj tnj tnj approved these changes

Assignees

@tnj tnj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmatsu @tnj