Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load cluster ID from database on startup #1165

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Load cluster ID from database on startup #1165

merged 1 commit into from
Apr 2, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Mar 29, 2024

The functionality works per default for all services that depend on the commons-persistence module. mirror-service at the moment does not, hence it will use a randomly generated cluster ID that is out-of-sync with the other services.

Also include the cluster ID in User-Agent headers of all HTTP clients.

Closes #925

@nscuro nscuro added the enhancement New feature or request label Mar 29, 2024
@nscuro nscuro force-pushed the issue-925 branch 2 times, most recently from 6961078 to 31d70e9 Compare March 29, 2024 18:06
The functionality works per default for all services that depend on the `commons-persistence` module. `mirror-service` at the moment does not, hence it will use a randomly generated cluster ID that is out-of-sync with the other services.

Also include the cluster ID in `User-Agent` headers of all HTTP clients.

Signed-off-by: nscuro <[email protected]>
Copy link

@nscuro nscuro added the blocked label Mar 29, 2024
Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mehab mehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nscuro nscuro added this to the 0.5.0 milestone Apr 2, 2024
@nscuro nscuro removed the blocked label Apr 2, 2024
@nscuro nscuro merged commit e8680b3 into main Apr 2, 2024
11 checks passed
@nscuro nscuro deleted the issue-925 branch April 2, 2024 10:10
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit that referenced this pull request Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework.

Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required.

Signed-off-by: nscuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distribute system identifier to all services
3 participants