-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load cluster ID from database on startup #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6961078
to
31d70e9
Compare
The functionality works per default for all services that depend on the `commons-persistence` module. `mirror-service` at the moment does not, hence it will use a randomly generated cluster ID that is out-of-sync with the other services. Also include the cluster ID in `User-Agent` headers of all HTTP clients. Signed-off-by: nscuro <[email protected]>
|
VinodAnandan
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mehab
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
2 tasks
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
that referenced
this pull request
Apr 22, 2024
This enables access to values in the `CONFIGPROPERTY` table through Quarkus' configuration management framework. Because the cluster ID introduced in #1165 is just a config property, the logic around `ClusterInfo` is no longer required. Signed-off-by: nscuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality works per default for all services that depend on the
commons-persistence
module.mirror-service
at the moment does not, hence it will use a randomly generated cluster ID that is out-of-sync with the other services.Also include the cluster ID in
User-Agent
headers of all HTTP clients.Warning
Depends on DependencyTrack/hyades-apiserver#639
Closes #925