Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove created and updated fields from vuln policy schema #531

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 18, 2024

Description

Removes the created and updated fields from vulnerability policy schema.

Instead, these fields are auto-populated during bundle synchronization with the database.

Addressed Issue

Closes DependencyTrack/hyades#1015

Additional Details

  • Migrated remaining queries from VulnerabilityPolicyQueryManager to the JDBI VulnerabilityPolicyDao
  • Introduced JDBI Jackson2 plugin to deal with JSON-serialized fields

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Jan 18, 2024
VithikaS
VithikaS previously approved these changes Jan 23, 2024
Makes it easier to observe changes in the files, and update them if necessary. In this case, `created` and `updated` fields were removed.

Signed-off-by: nscuro <[email protected]>
We no longer use pre-packaged bundles in tests.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro force-pushed the issue-1015 branch 2 times, most recently from fd52da0 to 6f3afa2 Compare January 23, 2024 13:37
@nscuro nscuro merged commit c1fa8a1 into main Jan 24, 2024
6 checks passed
@nscuro nscuro deleted the issue-1015 branch January 24, 2024 15:33
@nscuro nscuro added this to the 5.3.0 milestone Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove created and updated fields from vulnerability policy schema
2 participants