Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept BOM uploads in Protobuf format #1071

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Feb 26, 2025

Description

Dependency-Track supports BOM uploads in JSON and XML format. Add it for Protobuf file format.

Addressed Issue

Closes DependencyTrack/hyades#1667

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added the enhancement New feature or request label Feb 26, 2025
@sahibamittal sahibamittal added this to the 5.6.0 milestone Feb 26, 2025
Copy link

codacy-production bot commented Feb 26, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.45% (target: -1.00%) 68.27% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c878dd1) 22418 18595 82.95%
Head commit (816c5c1) 22709 (+291) 18939 (+344) 83.40% (+0.45%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1071) 416 284 68.27%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal marked this pull request as draft February 26, 2025 16:39
@sahibamittal sahibamittal marked this pull request as ready for review February 27, 2025 16:32
@sahibamittal sahibamittal requested a review from nscuro February 27, 2025 16:33
@sahibamittal
Copy link
Collaborator Author

Code coverage check with 68.42% can be bypassed, it is complaining about covering all enum possibilities in ModelConverterProto.

nscuro
nscuro previously approved these changes Mar 3, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nitpicks, otherwise looks good!

@nscuro nscuro changed the title Issue-1684 : add support for bom protobuf file upload Accept BOM uploads in Protobuf format Mar 3, 2025
@nscuro nscuro merged commit 184cfea into main Mar 4, 2025
8 of 9 checks passed
@nscuro nscuro deleted the issue-1684-support-protobuf-format-bom-upload branch March 4, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept BOM uploads in Protobuf format
2 participants