Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Handle GitHub GraphQL API rate limiting #4581

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jan 25, 2025

Description

Handles GitHub GraphQL API rate limiting.

  • Migrates the GitHub Advisories mirroring logic to the Open-Vulnerability-Project client.
  • Utilizes incremental mirroring similar to how it's done for the NVD REST API.
  • Adapts a more efficient synchronization logic, as already utilized by NVD REST API mirroring.

Addressed Issue

Fixes #4291
Fixes #2497
Backports #4578

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

* Migrates the GitHub Advisories mirroring logic to the Open-Vulnerability-Project client.
* Utilizes incremental mirroring similar to how it's done for the NVD REST API.
* Adapts a more efficient synchronization logic, as already utilized by NVD REST API mirroring.

Fixes DependencyTrack#4291
Fixes DependencyTrack#2497

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Jan 25, 2025
@nscuro nscuro added this to the 4.12.3 milestone Jan 25, 2025
This was not necessary in `master` since we disabled the L2 cache globally there.

Signed-off-by: nscuro <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.26% (target: -1.00%) 57.18% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5716b02) 22604 17905 79.21%
Head commit (c6949ba) 22570 (-34) 17937 (+32) 79.47% (+0.26%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4581) 376 215 57.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 031e0b8 into DependencyTrack:4.12.x Jan 25, 2025
6 of 7 checks passed
@nscuro nscuro deleted the backport-pr-4578 branch January 25, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant