Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project.active being nullable #4415

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Nov 27, 2024

Description

Fixes project.active being nullable.

Ensure the field defaults to true, both in Java and the database. During upgrade, migrate all values that are currently null to true.

Solidify this change by switching project.active from Boolean to boolean. Adjust logic that previously had to check for null.

Addressed Issue

Fixes #4410

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Ensure the field defaults to `true`, both in Java and the database. During upgrade, migrate all values that are currently `null` to `true`.

Solidify this change by switching `project.active` from `Boolean` to `boolean`. Adjust logic that previously had to check for `null`.

Fixes DependencyTrack#4410

Signed-off-by: nscuro <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (66c36ba) 22581 17875 79.16%
Head commit (42b91e8) 22588 (+7) 17880 (+5) 79.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4415) 10 10 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 9b015c3 into DependencyTrack:master Nov 28, 2024
11 checks passed
@nscuro nscuro deleted the issue-4410 branch November 28, 2024 17:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/4.12.2 PRs to be backported to version 4.12.2 defect Something isn't working
Projects
None yet
1 participant