Backport: Fix excessive memory usage of portfolio repository meta analysis #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task was fetching all projects of the entire portfolio at once, which couldn't be garbage collected until the task finished, causing excessive prolonged memory usage for larger portfolios. Fetch components in batches of up to 1000 instead. There a lot more about this task that could be optimized, but for the time being, this change should fix the most pressing issue. See DependencyTrack#4124 (reply in thread) for details. Signed-off-by: nscuro <[email protected]>
…po meta analysis Turns out that all `Component` and `RepositoryMetaComponent` instances touched during the analysis piled up in DataNucleus' L1 cache. By evicting them once no longer needed, this issue can be prevented. Also, components were queried with the default fetch plan, which includes various (large) fields that are not required for meta analysis. Now using a dedicated fetch group to only retrieve fields that are needed. Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes excessive memory usage of portfolio repository meta analysis.
Addressed Issue
Backports #4311
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly