-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set license name instead of ID when using custom license #3915
Conversation
Signed-off-by: Ross Murphy <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
I actually don't think the unit test I added is necessary, will remove it. |
Signed-off-by: Ross Murphy <[email protected]>
Thanks @2000rosser! Do you think you could add a test for this scenario here? https://github.com/DependencyTrack/dependency-track/blob/master/src/test/java/org/dependencytrack/resources/v1/BomResourceTest.java Have a look at the existing export tests, and either extend them or add a smaller test case that's scoped to only this problem. We want to ensure that, given a component with custom license, the exported BOM looks like expected ( |
@nscuro Sure, I'll take a look and add a test for it |
Signed-off-by: Ross Murphy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @2000rosser!
Description
A valid SPDX is required when using the ID field for licenses. If the license is a custom license, use the name field instead.
Addressed Issue
#3897
Checklist