Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoint for tag deletion #3896

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Jun 29, 2024

Description

Adds REST endpoint for tag deletion.

image

Addressed Issue

Relates to #586

Additional Details

Frontend PR: DependencyTrack/frontend#928

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added the enhancement New feature or request label Jun 29, 2024
@nscuro nscuro added this to the 4.12 milestone Jun 29, 2024
@nscuro nscuro force-pushed the tag-delete-endpoint branch from 8b624e3 to 7bdb549 Compare June 30, 2024 10:27
Copy link

codacy-production bot commented Jun 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 88.03% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a2b2a66) 21963 16714 76.10%
Head commit (d8ac537) 22074 (+111) 16811 (+97) 76.16% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3896) 117 103 88.03%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro force-pushed the tag-delete-endpoint branch 5 times, most recently from 51d6409 to c322fc8 Compare June 30, 2024 13:24
@nscuro nscuro marked this pull request as ready for review June 30, 2024 13:30
@nscuro nscuro force-pushed the tag-delete-endpoint branch from c322fc8 to d8ac537 Compare June 30, 2024 16:49
@nscuro nscuro merged commit e643409 into DependencyTrack:master Jun 30, 2024
11 checks passed
@nscuro nscuro deleted the tag-delete-endpoint branch June 30, 2024 17:22
@nscuro nscuro mentioned this pull request Jun 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant