-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autocreate project with tags #3843
feat: autocreate project with tags #3843
Conversation
Refs: 1674 Signed-off-by: JCHacking <[email protected]>
I like it. Can you add a test with tags populated? |
Refs: 1674 Signed-off-by: JCHacking <[email protected]>
Sure! Tests added |
Refs: 1674 Signed-off-by: JCHacking <[email protected]>
I see that the test has failed, I imagine that it is because it is not the same object since one is the tags only with name and the others are the tags obtained from the persistence that will have more properties. I should only make an assertEquals of the list of strings with the name of the tags, right? |
Yes. Consider using AssertJ's fluent assertions, like so: assertThat(project.getTags())
.extracting(Tag::getName)
.containsExactlyInAnyOrder("foo", "bar"); |
Refs: 1674 Signed-off-by: JCHacking <[email protected]>
Fixed it with your suggestion, thanks!! |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: nscuro <[email protected]> DependencyTrack#3843 added the parameter to the JSON-based `PUT /v1/bom` endpoint.
Description
To be able to upload a bom and auto-create the project with specific tags
Addressed Issue
#1674
Additional Details
I have added the optional property to the PUT method to upload BOM files, I have not programmed much in Java so any suggestion to improve this PR is welcome.
Thanks!!!
Checklist