Fix invalid Mattermost notification template; Add more thorough publisher tests #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DependencyTrack#3093 Signed-off-by: nscuro <[email protected]>
Signed-off-by: nscuro <[email protected]>
Fixes DependencyTrack#2838 Signed-off-by: nscuro <[email protected]>
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Oct 23, 2023
Ported from DependencyTrack/dependency-track#3095 Tests have not been ported, because the publishing of notifications now resides in the hyades notification-publisher, whereas the templates are still kept in the API server. It doesn't make sense to duplicate the template files to two repositories, risking that they become out-of-sync. Signed-off-by: nscuro <[email protected]>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a defect in the Mattermost notification template that caused invalid JSON to be produced for
PROJECT_AUDIT_CHANGEandNEW_VULNERABLE_DEPENDENCYnotifications.While working on this, I noticed that our test coverage for notification publishers is quite bad. We need a way to ensure that the JSON we send to external services is correct, and we also need a way to ensure that we do not introduce regressions when working on the code. Thus, this PR also includes extensive tests for all notification publishers.
Addressed Issue
Fixes #2838
Fixes #3093
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly